bharos commented on PR #2927: URL: https://github.com/apache/iceberg-python/pull/2927#issuecomment-3770606998
> Thanks for the fix. A few things to check for HMS properties that I can remember: > > 1. If an external tool happens to set a property with the same name as an Iceberg-managed one, we need to make sure Iceberg's value should take predence. > 2. If someone removes a property through Iceberg, make sure it actually gets deleted. Right now it might come back from the old HMS state after the merge. > 3. Things like `EXTERNAL`, `table_type`, `metadata_location` should always come from Iceberg, not be carried over from old HMS state. > 4. Worth expanding the tests to test to check for removing a property and checking it is removed, and Iceberg value preservation. > CC: @kevinjqliu @Fokko Makes sense. Added more tests to check these cases, also the code gives precedence to iceberg properties, PTAL and let me know if you find any issues. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
