liurenjie1024 commented on code in PR #2014:
URL: https://github.com/apache/iceberg-rust/pull/2014#discussion_r2706455310
##########
crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs:
##########
@@ -429,4 +477,97 @@ mod tests {
let predicate = convert_to_iceberg_predicate(sql);
assert_eq!(predicate, None);
}
+
+ #[test]
Review Comment:
We recently added support for sqllogictests, see
https://github.com/liurenjie1024/iceberg-rust/blob/666a9fe1aaf1692583d6f44e4f7a1d52a688b217/crates/sqllogictest/testdata/schedules/df_test.toml#L19
It would be better if we also include such sql logic tests in spite of ut.
##########
crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs:
##########
@@ -128,6 +128,54 @@ fn to_iceberg_predicate(expr: &Expr) -> TransformedResult {
}
to_iceberg_predicate(&c.expr)
}
+ Expr::Like(Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ case_insensitive,
+ }) => {
+ // Only support simple prefix patterns (e.g., 'prefix%')
+ // Escape characters and case-insensitive matching are not
supported yet
+ if escape_char.is_some() || *case_insensitive {
Review Comment:
IIRC, iceberg's starts with is case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
