nssalian commented on code in PR #2928:
URL: https://github.com/apache/iceberg-python/pull/2928#discussion_r2706483145
##########
pyiceberg/table/__init__.py:
##########
@@ -1618,7 +1618,7 @@ def __datafusion_table_provider__(self) ->
IcebergDataFusionTable:
iceberg_table = catalog.create_table("default.test",
schema=data.schema)
iceberg_table.append(data)
ctx = SessionContext()
- ctx.register_table_provider("test", iceberg_table)
+ ctx.register_table("test", iceberg_table)
Review Comment:
nit: Should we document the TableProvider change for datafusion? I couldn't
find the PR that did this but worth adding a doc string to explain this. Could
even link the one in the PR description:
https://datafusion.apache.org/python/autoapi/datafusion/context/index.html#datafusion.context.SessionContext.register_table_provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
