kevinjqliu commented on code in PR #2929:
URL: https://github.com/apache/iceberg-python/pull/2929#discussion_r2706648183
##########
dev/hive/Dockerfile:
##########
Review Comment:
same logic, just reordered
##########
dev/spark/Dockerfile:
##########
Review Comment:
same logic, just reordered
##########
.github/workflows/python-ci.yml:
##########
@@ -85,6 +85,27 @@ jobs:
- name: Install
run: make install
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v3
+
+ - name: Build and cache Spark image
+ uses: docker/build-push-action@v6
+ with:
+ context: dev/spark
+ load: true
+ tags: pyiceberg-spark:latest
+ cache-from: type=gha,scope=spark
+ cache-to: type=gha,mode=max,scope=spark
Review Comment:
docs for `cache-from` and `cache-to`:
https://docs.docker.com/reference/cli/docker/buildx/build/#cache-from
https://docs.docker.com/reference/cli/docker/buildx/build/#cache-to
##########
dev/spark/Dockerfile:
##########
@@ -18,10 +18,10 @@ ARG BASE_IMAGE_SPARK_VERSION=4.0.1
FROM apache/spark:${BASE_IMAGE_SPARK_VERSION}
# Dependency versions - keep these compatible
+# Changing these will invalidate the JAR download cache layer
ARG ICEBERG_VERSION=1.10.1
ARG ICEBERG_SPARK_RUNTIME_VERSION=4.0_2.13
ARG HADOOP_VERSION=3.4.1
-ARG SCALA_VERSION=2.13
Review Comment:
unreferenced, so removing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
