nssalian opened a new pull request, #2932:
URL: https://github.com/apache/iceberg-python/pull/2932
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
In #2928, the `uv.lock` wasn't generated correctly after a dependency change.
Adding the following changes:
1. `make uv-lock` to generate one when modifying dependencies
2. `make uv-lock-check` to check if the `uv.lock` is up to date
3. Adding a pre-commit config to check the `uv.lock` and fail if not updated
correctly (uses 2.)
4. Documentation change in `mkdocs/docs/contributing.md` to add instructions
for contributors.
## Are these changes tested?
Locally.
Added some of the dependencies in #2928 without modifying the lock file and
ran `pre-commit run --all-files` to observe the following failure message
```
uv lock file
check.......................................................Failed
- hook id: uv-lock-check
- exit code: 2
uv lock --check
Resolved 221 packages in 93ms
The lockfile at `uv.lock` needs to be updated, but `--check` was provided.
To update the lockfile, run `uv lock`.
make: *** [uv-lock-check] Error 1
```
## Are there any user-facing changes?
No. Useful for contributions that change versions/ dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
