zhjwpku commented on code in PR #519:
URL: https://github.com/apache/iceberg-cpp/pull/519#discussion_r2708382319
##########
src/iceberg/update/snapshot_update.h:
##########
@@ -103,25 +107,75 @@ class ICEBERG_EXPORT SnapshotUpdate : public
PendingUpdate {
/// \brief Write data manifests for the given data files
///
- /// \param data_files The data files to write
+ /// \tparam Iterator Iterator type that dereferences to
std::shared_ptr<DataFile>
+ /// \param begin Iterator to the beginning of the data files range
+ /// \param end Iterator to the end of the data files range
/// \param spec The partition spec to use
/// \param data_sequence_number Optional data sequence number for the files
/// \return A vector of manifest files
- /// TODO(xxx): Change signature to accept iterator begin/end instead of
vector to avoid
- /// intermediate vector allocations (e.g., from DataFileSet)
+ // TODO(xxx): write manifests in parallel
+ template <typename Iterator>
Result<std::vector<ManifestFile>> WriteDataManifests(
- const std::vector<std::shared_ptr<DataFile>>& data_files,
Review Comment:
reasonable, will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
