blcksrx commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2708502120
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -104,18 +160,27 @@ public void onRemoval(TableIdentifier tableIdentifier,
Table table, RemovalCause
}
private Cache<TableIdentifier, Table> createTableCache(Ticker ticker) {
- Caffeine<Object, Object> cacheBuilder = Caffeine.newBuilder().softValues();
-
- if (expirationIntervalMillis > 0) {
- return cacheBuilder
- .removalListener(new MetadataTableInvalidatingRemovalListener())
- .executor(Runnable::run) // Makes the callbacks to removal listener
synchronous
- .expireAfterAccess(Duration.ofMillis(expirationIntervalMillis))
- .ticker(ticker)
- .build();
+
+ if (expirationIntervalMillis <= 0) {
+ return Caffeine.newBuilder().softValues().build();
}
- return cacheBuilder.build();
+ Caffeine<TableIdentifier, Table> cacheBuilder =
+ Caffeine.newBuilder()
+ .softValues()
+ .removalListener(new MetadataTableInvalidatingRemovalListener())
+ .executor(Runnable::run) // Makes the callbacks to removal
listener synchronous
+ .ticker(ticker);
+
+ switch (cacheExpirationPolicy) {
+ case EXPIRE_AFTER_WRITE:
+ return
cacheBuilder.expireAfterWrite(Duration.ofMillis(expirationIntervalMillis)).build();
+ case EXPIRE_AFTER_ACCESS:
+ return
cacheBuilder.expireAfterAccess(Duration.ofMillis(expirationIntervalMillis)).build();
Review Comment:
I have changed the PR and updated the PR description, as you have suggested
I have added a new configuration `cache.expire-after-write-ms` that by default
the value is 0 (disabled) to be compatible with current cache behaviour.
In nutshell now its possible to have these 4 options:
- No cache policy
- Expire After Access
- Expire After Write
- Expire After Access and Expire After Write both together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
