nastra commented on code in PR #15082:
URL: https://github.com/apache/iceberg/pull/15082#discussion_r2708909215
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -4336,7 +3587,7 @@ private RESTCatalog catalog(RESTCatalogAdapter adapter) {
return catalog;
}
- private RESTCatalog catalog(
+ public static RESTCatalog catalog(
Review Comment:
in that case I would just duplicate this for now and only refactor once we
have 3 or more places where this is needed. I believe this is how we typically
handled it in the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
