smaheshwar-pltr commented on code in PR #15092:
URL: https://github.com/apache/iceberg/pull/15092#discussion_r2709270899


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -2691,6 +2696,8 @@ public void testConcurrentReplaceTransactions() {
     secondReplace.commitTransaction();
 
     Table afterSecondReplace = catalog.loadTable(TABLE);
+    // All three successfully committed snapshots should be present
+    assertThat(afterSecondReplace.snapshots()).hasSize(3);

Review Comment:
   Makes sense - I've updated the PR description in the meantime to cover this.
   (Any concurrent change to a table's snapshots causes the replace transaction 
to fail entirely for the REST catalog, due to server-side row-lineage 
validation. I'll put up an issue to track, actually)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to