ayushtkn commented on code in PR #15099:
URL: https://github.com/apache/iceberg/pull/15099#discussion_r2712548146
##########
core/src/test/java/org/apache/iceberg/data/DataTestBase.java:
##########
@@ -595,6 +598,7 @@ public void
testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Literal<?> d
}
@Test
+ @SuppressWarnings("checkstyle:AssertThatThrownByWithMessageCheck")
Review Comment:
the moment I touched this test file, it fails for an existing issue in this
test
```
> Task :iceberg-core:checkstyleTest
[ant:checkstyle] [ERROR]
/Users/ayushsaxena/code/iceberg/core/src/test/java/org/apache/iceberg/data/DataTestBase.java:613:
assertThatThrownBy must include a message check like .hasMessage(...)
[AssertThatThrownByWithMessageCheck]
> Task :iceberg-core:checkstyleTest FAILED
```
The `assertThatThrownBy` doesn't have `hasMessage`. So, I added this to make
the build pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
