edgao commented on PR #15094: URL: https://github.com/apache/iceberg/pull/15094#issuecomment-3781643706
@singhpk234 how does this look? Looking through AwsClientFactories, I think we could probably also refactor it to accept a mocked `AwsClientProperties` object + assert that we at least called `awsClientProperties.applyRetryConfigurations`. But that would have been more code churn, and it still doesn't _really_ verify that the client object was constructed correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
