Copilot commented on code in PR #15104: URL: https://github.com/apache/iceberg/pull/15104#discussion_r2715152518
########## spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/metrics/AddedFileSizeInBytes.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source.metrics; + +import org.apache.spark.sql.connector.metric.CustomSumMetric; + +public class AddedFileSizeInBytes extends CustomSumMetric { + + static final String NAME = "addedFileSizeInBytes"; + + @Override + public String name() { + return NAME; + } + + @Override + public String description() { + return "number of added file size (bytes)"; Review Comment: The description should be "total size of added files (bytes)" or "added file size in bytes" rather than "number of added file size (bytes)" since file size is not a countable quantity. ```suggestion return "total size of added files (bytes)"; ``` ########## spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/metrics/RemovedFileSizeInBytes.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source.metrics; + +import org.apache.spark.sql.connector.metric.CustomSumMetric; + +public class RemovedFileSizeInBytes extends CustomSumMetric { + + static final String NAME = "removedFileSizeInBytes"; + + @Override + public String name() { + return NAME; + } + + @Override + public String description() { + return "number of removed file size (bytes)"; Review Comment: The description should be "total size of removed files (bytes)" or "removed file size in bytes" rather than "number of removed file size (bytes)" since file size is not a countable quantity. ```suggestion return "total size of removed files (bytes)"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
