geruh commented on code in PR #14927: URL: https://github.com/apache/iceberg/pull/14927#discussion_r2715187064
########## core/src/test/java/org/apache/iceberg/rest/TestErrorHandlers.java: ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.apache.iceberg.exceptions.RESTException; +import org.apache.iceberg.rest.responses.ErrorResponse; +import org.junit.jupiter.api.Test; + +class TestErrorHandlers { Review Comment: nit: public class TestErrorHandlers ########## core/src/test/java/org/apache/iceberg/rest/TestErrorHandlers.java: ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.apache.iceberg.exceptions.RESTException; +import org.apache.iceberg.rest.responses.ErrorResponse; +import org.junit.jupiter.api.Test; + +class TestErrorHandlers { + + @Test + public void testErrorHandlerIncludesCodeAndType() { + ErrorResponse error = + ErrorResponse.builder() + .responseCode(422) + .withType("ValidationException") + .withMessage("Invalid input") + .build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessageContaining( + "Unable to process (code: 422, type: ValidationException): Invalid input"); + } + + @Test + public void testErrorHandlerWithCodeOnly() { + ErrorResponse error = ErrorResponse.builder().responseCode(422).build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessageContaining("Unable to process (code: 422, type: null): null"); Review Comment: nit: Consider using `.hasMessage()` instead of `.hasMessageContaining()` since you're verifying the exact message format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
