amogh-jahagirdar commented on code in PR #14886:
URL: https://github.com/apache/iceberg/pull/14886#discussion_r2717644775
##########
core/src/main/java/org/apache/iceberg/actions/BaseDeleteOrphanFiles.java:
##########
@@ -29,5 +29,8 @@
interface BaseDeleteOrphanFiles extends DeleteOrphanFiles {
@Value.Immutable
- interface Result extends DeleteOrphanFiles.Result {}
+ interface Result extends DeleteOrphanFiles.Result {
+ @Override
+ long orphanFilesCount();
Review Comment:
I think there's a way for immutables to express a default here? I think
that'll be important for compatibility so we don't break upgrades at runtime
from 1.10 to 1.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
