rdblue commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2717904400
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1309,27 +1312,52 @@ public ReadBuilder createReaderFunc(
Preconditions.checkArgument(
this.batchedReaderFunc == null,
"Cannot set reader function: batched reader function already set");
+ Preconditions.checkArgument(
+ this.batchedReaderFuncWithSchema == null,
+ "Cannot set reader function: batched reader function with schema
already set");
Preconditions.checkArgument(
this.readerFunction == null, "Cannot set reader function: reader
function already set");
this.readerFunction = new BinaryReaderFunction(newReaderFunction);
return this;
}
- public ReadBuilder createBatchedReaderFunc(Function<MessageType,
VectorizedReader<?>> func) {
+ public ReadBuilder createBatchedReaderFunc(
Review Comment:
Nit: renaming the method argument causes this to appear like a new method.
Changing it back would result in fewer changes and a more readable patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
