kevinjqliu commented on code in PR #2941:
URL: https://github.com/apache/iceberg-python/pull/2941#discussion_r2718036601
##########
pyiceberg/catalog/hive.py:
##########
@@ -551,23 +551,30 @@ def commit_table(
if hive_table and current_table:
# Table exists, update it.
- new_parameters = _construct_parameters(
+
+ # Note on table properties:
+ # - Iceberg table properties are stored in both HMS and
Iceberg metadata JSON.
+ # - Updates are reflected in both locations
+ # - Existing HMS table properties (set by external systems
like Hive/Spark) are preserved.
+ #
+ # While it is possible to modify HMS table properties
through this API, it is not recommended:
+ # - New/Updated HMS table properties will also be stored
in Iceberg metadata (even though it's HMS-specific)
+ # - HMS properties cannot be deleted since they are not
visible to Iceberg
Review Comment:
yea good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
