aokolnychyi commented on a change in pull request #1715:
URL: https://github.com/apache/iceberg/pull/1715#discussion_r525598803
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -47,9 +87,9 @@
protected Dataset<Row> buildValidDataFileDF(SparkSession spark, String
tableName) {
JavaSparkContext context = new JavaSparkContext(spark.sparkContext());
Broadcast<FileIO> ioBroadcast =
context.broadcast(SparkUtil.serializableFileIO(table()));
- String allManifestsMetadataTable = metadataTableName(tableName,
MetadataTableType.ALL_MANIFESTS);
- Dataset<ManifestFileBean> allManifests =
spark.read().format("iceberg").load(allManifestsMetadataTable)
+ Dataset<ManifestFileBean> allManifests = loadMetadataTable(spark,
tableName, table().location(),
+ MetadataTableType.ALL_MANIFESTS)
Review comment:
If we do a static import for `ALL_MANIFESTS`, will it fit on one line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
