zhjwpku commented on code in PR #531: URL: https://github.com/apache/iceberg-cpp/pull/531#discussion_r2721579942
########## mkdocs/docs/index.md: ########## @@ -129,6 +129,30 @@ pre-commit install This will setup a git pre-commit-hook that is executed on each commit and will report the linting problems. To run all hooks on all files use `pre-commit run -a`. +### AI-Assisted Contributions + +The Apache Iceberg C++ community has the following policy for AI-assisted PRs: + +- The PR author should **understand the core ideas** behind the implementation **end-to-end**, and be able to justify the design and code during review. +- **Calls out unknowns and assumptions**. It's okay to not fully understand some bits of AI generated code. You should comment on these cases and point them out to reviewers so that they can use their knowledge of the codebase to clear up any concerns. For example, you might comment "calling this function here seems to work but I'm not familiar with how it works internally, I wonder if there's a race condition if it is called concurrently". + +#### Why fully AI-generated PRs without understanding are not helpful + +Today, AI tools cannot reliably make complex changes to the codebase on their own, which is why we rely on pull requests and code review. + +The purposes of code review are: + +1. Finish the intended task. +2. Share knowledge between authors and reviewers, as a long-term investment in the project. For this reason, even if someone familiar with the codebase can finish a task quickly, we're still happy to help a new contributor work on it even if it takes longer. + +An AI dump for an issue doesn’t meet these purposes. Maintainers could finish the task faster by using AI directly, and the submitters gain little knowledge if they act only as a pass through AI proxy without understanding. Review Comment: ```suggestion An AI dump for an issue doesn't meet these purposes. Maintainers could finish the task faster by using AI directly, and the submitters gain little knowledge if they act only as a pass through AI proxy without understanding. ``` Should we stick to `'` since it's a plain ASCII? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
