mxm opened a new pull request, #15123: URL: https://github.com/apache/iceberg/pull/15123
FlinkParquetWriter already handles default values correctly, but the feature wasn't tested via DataTestBase. This required implementing two additional test methods `supportsDefaultValues()` and `writeAndValidate(Schema writeSchema, Schema expectedSchema)`. In the course of doing that, I found there are some inconsistencies with regard to iterating over the expected records and swapped actual / expected parameters in the assert method, which led to test failures. I addressed these as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
