rdblue commented on a change in pull request #1778:
URL: https://github.com/apache/iceberg/pull/1778#discussion_r525623524
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -156,10 +156,13 @@
this.io = io;
this.encryptionManager = encryptionManager;
this.caseSensitive = caseSensitive;
-
- this.batchReadsEnabled =
options.get("vectorization-enabled").map(Boolean::parseBoolean).orElseGet(() ->
- PropertyUtil.propertyAsBoolean(table.properties(),
- TableProperties.PARQUET_VECTORIZATION_ENABLED,
TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
+ boolean batchReadsSparkSessionConf =
SparkSession.active().sparkContext().getConf()
+ .getBoolean("read.parquet.vectorization.enabled", true);
+ boolean batchReadsEnabledTableProp =
options.get("vectorization-enabled").map(Boolean::parseBoolean).orElseGet(() ->
+ PropertyUtil.propertyAsBoolean(table.properties(),
+ TableProperties.PARQUET_VECTORIZATION_ENABLED,
+ TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
Review comment:
Looks like these 4 lines didn't actually change. Can you revert the
whitespace changes here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
