singhpk234 commented on code in PR #14820:
URL: https://github.com/apache/iceberg/pull/14820#discussion_r2723388351
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1685,8 +1711,14 @@ public void testPartitionsTableDeleteStats() {
totalSizeInBytes(table.snapshot(firstCommitId).addedDataFiles(table.io())))
.set("position_delete_record_count", 2L) // should be incremented
now
.set("position_delete_file_count", 2) // should be incremented now
+ .set(
+ "total_position_delete_file_size_in_bytes",
+ totalDeleteFileSizeInBytes(
+
table.snapshot(posDeleteCommitId).addedDeleteFiles(table.io()),
Review Comment:
can we compute the iterator once and reuse it in both position / equality
delete
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1685,8 +1711,14 @@ public void testPartitionsTableDeleteStats() {
totalSizeInBytes(table.snapshot(firstCommitId).addedDataFiles(table.io())))
.set("position_delete_record_count", 2L) // should be incremented
now
.set("position_delete_file_count", 2) // should be incremented now
+ .set(
+ "total_position_delete_file_size_in_bytes",
+ totalDeleteFileSizeInBytes(
+
table.snapshot(posDeleteCommitId).addedDeleteFiles(table.io()),
Review Comment:
nit: can we compute the iterator once and reuse it in both position /
equality delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
