geruh opened a new pull request, #2953:
URL: https://github.com/apache/iceberg-python/pull/2953
# Rationale for this change
While working on the `ty` integration, I've been auditing the pre-commit
hooks. This PR removes the `flynt` pre-commit hook since it;s redundant with
ruff's `UP031` and `UP032` rules which are already enabled via the `UP`
selector in our `ruff.toml`.
`flynt` converts `.format()` and `%` style string formatting to f-strings.
Ruff's pyupgrade rules do the same:
- **UP031**: `printf-string-formatting` - converts `%` formatting
- **UP032**: `f-string` - converts `.format()` calls
and both produce identical results
## Are these changes tested?
make lint
Manual tests:
Code: `"Hello, {}".format(name)`
- flynt: `f"Hello, {name}"`
- ruff: `f"Hello, {name}"`
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
