stats-dev commented on code in PR #2948:
URL: https://github.com/apache/iceberg-python/pull/2948#discussion_r2726152355


##########
pyiceberg/catalog/glue.py:
##########


Review Comment:
   I added s3.profile-name and client.profile-name to the configuration docs.
   
   Plus, while updating the docs, I noticed that the existing descriptions used 
"static profile" in table. I felt that "AWS profile" is more intuitive and 
accurate, so I updated the descriptions for glue, dynamodb, s3, and  client 
table.
    sections to maintain consistency.
   
   Let me know if you prefer keeping it as "static" (instead of AWS profile..). 
Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to