marton-bod commented on a change in pull request #1612: URL: https://github.com/apache/iceberg/pull/1612#discussion_r525996602
########## File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveSchemaConverter.java ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive; + +import java.util.ArrayList; +import java.util.List; +import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.ListTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.MapTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.StructTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +class HiveSchemaConverter { + private int id; + + HiveSchemaConverter() { + id = 0; + } + + List<Types.NestedField> convert(List<String> names, List<TypeInfo> typeInfos) { + List<Types.NestedField> result = new ArrayList<>(names.size()); + for (int i = 0; i < names.size(); ++i) { + result.add(Types.NestedField.optional(id++, names.get(i), convert(typeInfos.get(i)))); + } + + return result; + } + + Type convert(TypeInfo typeInfo) { + switch (typeInfo.getCategory()) { + case PRIMITIVE: + switch (((PrimitiveTypeInfo) typeInfo).getPrimitiveCategory()) { + case FLOAT: + return Types.FloatType.get(); + case DOUBLE: + return Types.DoubleType.get(); + case BOOLEAN: + return Types.BooleanType.get(); + case BYTE: + case SHORT: Review comment: It might make sense to throw an exception if the user wants to use these Hive types (byte, short, char, varchar, etc.) which do not exist in Iceberg. E.g. "unsupported Hive type (byte) for Iceberg tables. Consider using type (int) instead." - or something along the lines. Silently using a different Iceberg type than the one specified in the Hive DDL (e.g. Hive short -> Iceberg int) under the hood can violate the expectations of the user, for example regarding storage footprint, so it might be better to force a one-to-one type mapping. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
