RussellSpitzer commented on a change in pull request #1715:
URL: https://github.com/apache/iceberg/pull/1715#discussion_r526209598
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -86,6 +126,32 @@
return manifestDF.union(otherMetadataFileDF).union(manifestListDF);
}
+ protected static Dataset<Row> loadMetadataTable(SparkSession spark, String
tableName, String tableLocation,
+ MetadataTableType type) {
+ DataFrameReader noCatalogReader = spark.read().format("iceberg");
+ if (tableName.contains("/")) {
+ // Metadata location passed, load without a catalog
+ return noCatalogReader.load(tableName + "#" + type);
+ } else {
+ // Try catalog based name based resolution
+ try {
+ return spark.table(tableName + "." + type);
+ } catch (Exception e) {
Review comment:
Unfortunately these are unchecked from Scala so we do need to catch all
runtime exceptions, but I can do a check after the exception is caught if it is
a ParseException (2.4) or AnalysisException(3.0) and rethrow if it isn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
