zhjwpku opened a new pull request, #539:
URL: https://github.com/apache/iceberg-cpp/pull/539

   We have the convention that only header files should use the `_internal` 
suffix, so that iceberg_install_all_headers does not install them. However, we 
have some existing .cc files with the
    _internal suffix, which should be fixed.
   
   This commit only addresses json_internal.h/.cc, since we discussed renaming 
them to json_serde_internal.h and json_serde.cc in #534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to