geruh commented on PR #2973: URL: https://github.com/apache/iceberg-python/pull/2973#issuecomment-3809370926
Yeah it's super cool! The comparison helped uncover some other things with our release too. But I did some testing on my fork with these changes, and ran a nightly build with this and it worked pretty well! Nightly run: https://github.com/geruh/iceberg-python/actions/runs/21427296271 PyPi test env deploy: https://test.pypi.org/project/pyiceberg-geruh/ The change becomes much simpler and we can add `ubuntu-24.04-arm` to the matrix. I'll paste the patch below against main (1f947a72f) for you check out! ``` Subject: [PATCH] Add Linux aarch64 wheel builds using native ARM runners --- Index: .github/workflows/pypi-build-artifacts.yml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/.github/workflows/pypi-build-artifacts.yml b/.github/workflows/pypi-build-artifacts.yml --- a/.github/workflows/pypi-build-artifacts.yml (revision 1f947a72f65632e5f6167ca9d56cef215906362a) +++ b/.github/workflows/pypi-build-artifacts.yml (revision 72f3daca16dc072ce9becb8662abb2ec396662a5) @@ -32,7 +32,7 @@ runs-on: ${{ matrix.os }} strategy: matrix: - os: [ ubuntu-latest, windows-latest, macos-15-intel, macos-latest ] + os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, macos-15-intel, macos-latest ] steps: - uses: actions/checkout@v6 @@ -59,7 +59,7 @@ # the repository, otherwise the tests will fail - name: Compile source distribution run: uv build --sdist - if: startsWith(matrix.os, 'ubuntu') + if: matrix.os == 'ubuntu-latest' - name: Build wheels uses: pypa/[email protected] @@ -77,7 +77,7 @@ - name: Add source distribution - if: startsWith(matrix.os, 'ubuntu') + if: matrix.os == 'ubuntu-latest' run: ls -lah dist/* && cp dist/* wheelhouse/ - uses: actions/upload-artifact@v4 Index: .github/workflows/svn-build-artifacts.yml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/.github/workflows/svn-build-artifacts.yml b/.github/workflows/svn-build-artifacts.yml --- a/.github/workflows/svn-build-artifacts.yml (revision 1f947a72f65632e5f6167ca9d56cef215906362a) +++ b/.github/workflows/svn-build-artifacts.yml (revision 72f3daca16dc072ce9becb8662abb2ec396662a5) @@ -32,7 +32,7 @@ runs-on: ${{ matrix.os }} strategy: matrix: - os: [ ubuntu-latest, windows-latest, macos-15-intel, macos-latest ] + os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, macos-15-intel, macos-latest ] steps: - uses: actions/checkout@v6 @@ -54,7 +54,7 @@ # the repository, otherwise the tests will fail - name: Compile source distribution run: uv build --sdist - if: startsWith(matrix.os, 'ubuntu') + if: matrix.os == 'ubuntu-latest' - name: Build wheels uses: pypa/[email protected] @@ -71,7 +71,7 @@ CIBW_SKIP: "cp3*t-*" - name: Add source distribution - if: startsWith(matrix.os, 'ubuntu') + if: matrix.os == 'ubuntu-latest' run: ls -lah dist/* && cp dist/* wheelhouse/ - uses: actions/upload-artifact@v4 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
