wgtmac commented on code in PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541#discussion_r2736533987
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -151,7 +151,9 @@ function(resolve_arrow_dependency)
endif()
else()
set(ARROW_VENDORED FALSE)
- list(APPEND ICEBERG_SYSTEM_DEPENDENCIES Arrow)
+ find_package(Arrow CONFIG REQUIRED)
Review Comment:
I think this is redundant, but it doesn't hurt to add this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
