rmannibucau commented on code in PR #15124: URL: https://github.com/apache/iceberg/pull/15124#discussion_r2738802325
########## docker/iceberg-flink-quickstart/Dockerfile: ########## @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Version arguments - can be overridden at build time +ARG FLINK_VERSION=2.0 + +FROM apache/flink:${FLINK_VERSION}-java21 + +SHELL ["/bin/bash", "-c"] + +# Copy LICENSE and NOTICE files for ASF compliance +COPY --chown=flink:flink LICENSE NOTICE /opt/flink/ + +# Redeclare ARG variables after FROM to make them available in subsequent layers +ARG ICEBERG_VERSION=1.10.1 +ARG ICEBERG_FLINK_RUNTIME_VERSION=2.0 +ARG ICEBERG_AWS_BUNDLE_VERSION=1.9.2 +ARG HADOOP_VERSION=3.3.4 + +# Switch to flink user for installation +USER flink + +WORKDIR /opt/flink + +# Install Iceberg Flink runtime and AWS bundle JARs +RUN echo "-> Install JARs: Dependencies for Iceberg" && \ + mkdir -p ./lib/iceberg && pushd $_ && \ + curl -fO https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-flink-runtime-${ICEBERG_FLINK_RUNTIME_VERSION}/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_FLINK_RUNTIME_VERSION}-${ICEBERG_VERSION}.jar && \ Review Comment: just a DNS thingy but `https://repo.maven.apache.org/maven2/` would be more reliable since it can fallback on google mirror if needed or have future optimizations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
