CTTY commented on code in PR #2080:
URL: https://github.com/apache/iceberg-rust/pull/2080#discussion_r2739429712
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -104,14 +102,8 @@ impl FileIO {
/// - If the path is a file or not exist, this function will be no-op.
/// - If the path is a empty directory, this function will remove the
directory itself.
/// - If the path is a non-empty directory, this function will remove the
directory and all nested files and directories.
- pub async fn remove_dir_all(&self, path: impl AsRef<str>) -> Result<()> {
- let (op, relative_path) = self.inner.create_operator(&path)?;
- let path = if relative_path.ends_with('/') {
- relative_path.to_string()
- } else {
- format!("{relative_path}/")
- };
- Ok(op.remove_all(&path).await?)
+ pub async fn delete_prefix(&self, path: impl AsRef<str>) -> Result<()> {
Review Comment:
This is a breaking change, the method is renamed to `delete_prefix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
