rdblue commented on a change in pull request #1525:
URL: https://github.com/apache/iceberg/pull/1525#discussion_r526465615



##########
File path: spark/src/main/java/org/apache/iceberg/actions/Actions.java
##########
@@ -77,6 +82,120 @@ public ExpireSnapshotsAction expireSnapshots() {
     return new ExpireSnapshotsAction(spark, table);
   }
 
+  /**
+   * Converts the provided table into an Iceberg table in place. The table 
will no longer be represented by it's
+   * previous provider in the session catalog and a new metadata directory 
will be created at the table's location.
+   *
+   * @param tableName Table to be converted
+   * @return {@link CreateAction} to perform migration
+   */
+  public static CreateAction migrate(String tableName) {

Review comment:
       I think not implementing these in Spark 2 is definitely a reason to 
reconsider this.
   
   What about somewhere in the middle? We could introduce an API that isn't 
static, then call its methods from the static ones here. Then we just need an 
implementation class, which we could load dynamically.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to