RussellSpitzer commented on a change in pull request #1525:
URL: https://github.com/apache/iceberg/pull/1525#discussion_r526478452
##########
File path: spark/src/main/java/org/apache/iceberg/actions/Actions.java
##########
@@ -77,6 +82,120 @@ public ExpireSnapshotsAction expireSnapshots() {
return new ExpireSnapshotsAction(spark, table);
}
+ /**
+ * Converts the provided table into an Iceberg table in place. The table
will no longer be represented by it's
+ * previous provider in the session catalog and a new metadata directory
will be created at the table's location.
+ *
+ * @param tableName Table to be converted
+ * @return {@link CreateAction} to perform migration
+ */
+ public static CreateAction migrate(String tableName) {
Review comment:
I still prefer having BaseActions with an Actions per module. I think
having two classes each which determine their implementation at runtime is not
much better than all the static method reflection currently in the PR. The user
experience would be worse, since there is a weird middle method to call, and we
still would have runtime exceptions for bad method calls.
Maybe I don't understand the API that isn't static plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
