jackye1995 commented on pull request #1633: URL: https://github.com/apache/iceberg/pull/1633#issuecomment-730018147
@rdblue Thanks for the comments, I have been debating with myself about the rename order, and I have changed the dropTable to be the last operation. For the commit part, I have also simplified the logic based on the suggestions. For the integration test part, one can run it by setting AWS credentials and a test bucket using environment variable `AWS_TEST_BUCKET` and run task `:iceberg-aws:integrationTest`. This should integrate well with Github actions. I am in the progress of requesting an account to run those tests for the open source community. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
