nastra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2742292292
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3SignRequestParser.java:
##########
@@ -29,6 +29,11 @@
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.util.JsonUtil;
+/**
+ * @deprecated since 1.11.0, will be removed in 1.12.0; use {@link
+ * org.apache.iceberg.rest.requests.RemoteSignRequestParser} instead.
+ */
+@Deprecated
Review Comment:
I actually liked that you switched the impl here to using functionality from
the new `RemoteSignRequestParser` for stuff, not sure why you decided to change
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
