kevinjqliu commented on code in PR #2979:
URL: https://github.com/apache/iceberg-python/pull/2979#discussion_r2742345133
##########
Makefile:
##########
@@ -66,11 +66,15 @@ install-uv: ## Ensure uv is installed
echo "uv is already installed."; \
fi
-setup-venv: ## Create virtual environment
- uv venv $(PYTHON_ARG)
+setup-venv: ## Create virtual environment (if not exists)
+ @if [ ! -d ".venv" ]; then \
Review Comment:
updated the pr to get rid of `setup-venv` entirely and let uv handle the
virtualenv
this will allow users to customize `UV_PROJECT_ENVIRONMENT` if desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
