rambleraptor commented on code in PR #15154:
URL: https://github.com/apache/iceberg/pull/15154#discussion_r2743551313
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -174,14 +182,71 @@ public Dataset<FileInfo> expireFiles() {
// fetch valid files after expiration
TableMetadata updatedMetadata = ops.refresh();
- Dataset<FileInfo> validFileDS = fileDS(updatedMetadata);
- // fetch files referenced by expired snapshots
+ // find IDs of expired snapshots
Review Comment:
Can you add some comments to break up these code sections? I think it helps
to understand the flow of the code
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -405,7 +409,7 @@ public long totalFilesCount() {
}
}
- private static class ReadManifest implements
FlatMapFunction<ManifestFileBean, FileInfo> {
+ protected static class ReadManifest implements
FlatMapFunction<ManifestFileBean, FileInfo> {
Review Comment:
Just making this protected seems fine, but I'd love to get another opinion
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
