brodiealexander commented on issue #1816: URL: https://github.com/apache/iceberg-rust/issues/1816#issuecomment-3820864510
I wanted to chime in and agree on @mdub 's points while also adding that inconsistent use of `impl ToString` is also an area for improvement. Lots of methods in `iceberg-rust` take a String as an input parameter rather than `impl ToString` which allows for &str, String, &String, and many other types to be passed in without having to write `.to_string()` in user-facing code. I just started a job where we're using Iceberg for data storage. In the long term, I'd like to lobby for `iceberg-rust` to be used. I'm not sure exactly how much time I'll have yet but my hope is to be able to help with this effort over the next few weeks and months. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
