Heatao commented on code in PR #15061:
URL: https://github.com/apache/iceberg/pull/15061#discussion_r2744402708
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/TestSparkWriteConf.java:
##########
@@ -631,6 +631,49 @@ private void testWriteProperties(List<Map<String, String>>
propertiesSuite) {
});
}
+ @TestTemplate
+ public void testExtraSnapshotMetadataPersistedOnRowLevelDelete() {
Review Comment:
Done! Added `testExtraSnapshotMetadataOnMergeOnReadDelete()` to explicitly
test the merge-on-read delete mode.
Also renamed the tests for clarity:
- `testExtraSnapshotMetadataOnCopyOnWriteDelete` - explicitly sets
copy-on-write mode
- `testExtraSnapshotMetadataOnMergeOnReadDelete` - explicitly sets
merge-on-read mode
- `testExtraSnapshotMetadataOnMetadataOnlyDelete` - tests the metadata-only
delete path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
