pvary commented on code in PR #14997:
URL: https://github.com/apache/iceberg/pull/14997#discussion_r2745155366
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -2150,4 +2157,90 @@ public void registerViewThatAlreadyExistsAsTable() {
assertThat(tableCatalog().dropTable(identifier)).isTrue();
}
+
+ @Test
+ public void concurrentIdenticalUpdates() {
Review Comment:
I have played around with this kind of tests in my Index PR, and it is
easier to check this directly on the Metadata.
Pseudo code:
```
ViewMetadata original = ...
ViewVersion newVersion = ...
ViewMetadata afterFirstChange =
ViewMetadata.buildFrom(original).addVersion(newVersion).build();
List<MetadataUpdate> changes = afterFirstChange.changes();
ViewMetadata.Builder metadataBuilder = IndexMetadata.buildFrom(original);
changes.forEach(update -> update.applyTo(metadataBuilder));
IndexMetadata afterReplayedChange = metadataBuilder.build();
assertThat(...);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
