brodiealexander commented on issue #2068:
URL: https://github.com/apache/iceberg-rust/issues/2068#issuecomment-3824916126

   That makes sense. For schema evolution from V0 to V1, is adding the column 
all that's required, or would that involve pieces outside of 
`iceberg-catalog-sql`? I suppose it's safe to assume everything is a table 
unless `iceberg_type` is present. 
   
   I could pursue a solution like this:
   (1) On first open, set a flag if `iceberg_type` is present. Something like 
`SqlCatalog.views_supported: bool`. We could then factor out the query strings 
into utility functions or constants like Java does and use match statements in 
the catalog code to select them based on whether the `iceberg_type` column is 
present. 
   (2) On first write, we can add the `iceberg_type` column to the table with 
the assumption that all rows were TABLEs and change the flag on SqlCatalog to 
match. 
   
   What do you think of this approach? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to