dramaticlly commented on issue #12586: URL: https://github.com/apache/iceberg/issues/12586#issuecomment-3825173775
> i think the issue lies here: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java#L468 > > it thould not add a DeleteFile to the Rewrite plan if it isn't live anymore. Chances are high that it got cleaned up already. > > Nevertheless, if the file isn't added to the CopyPlan, there is also no need for rewriting it. > > [@dramaticlly](https://github.com/dramaticlly) what's your opinion? Thanks for the ping! I recall discussing this with @szehon-ho and @flyrain previously. When rewriting file paths in delete manifests, we deliberately maintain the original entry count to preserve the manifest's semantic meaning to. Here's how it works: - Live position delete entries: We copy the actual position delete files (with path rewritten) to the new location and update their corresponding entries in the new delete manifests. - Non-live (deleted) position delete entries: We do not copy these files (since they're no longer needed), but we still rewrite their entries in the new delete manifests to preserve the manifest structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
