wgtmac commented on code in PR #551:
URL: https://github.com/apache/iceberg-cpp/pull/551#discussion_r2748679372


##########
src/iceberg/constants.h:
##########
@@ -30,6 +30,11 @@
 
 namespace iceberg {
 
+/// \brief Iceberg table format versions
+constexpr int8_t kFormatVersion1 = 1;

Review Comment:
   TBH, I think using 1/2/3 as before looks better...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to