nastra commented on code in PR #15057:
URL: https://github.com/apache/iceberg/pull/15057#discussion_r2754626409
##########
core/src/main/java/org/apache/iceberg/rest/ETagProvider.java:
##########
@@ -19,19 +19,32 @@
package org.apache.iceberg.rest;
import java.nio.charset.StandardCharsets;
+import java.util.Map;
+import java.util.TreeMap;
+import org.apache.iceberg.relocated.com.google.common.base.Joiner;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.hash.HashFunction;
import org.apache.iceberg.relocated.com.google.common.hash.Hashing;
class ETagProvider {
private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed();
+ private static final Joiner.MapJoiner PARAMS_JOINER =
Joiner.on(",").withKeyValueSeparator("=");
+ private static final Joiner COMMA = Joiner.on(',');
+
private ETagProvider() {}
- public static String of(String metadataLocation) {
+ public static String of(String metadataLocation, Map<String, String> params)
{
Review Comment:
nit: maybe just create an overloaded method that keeps the original
signature so that you don't have to pass `null` in some of the calling sites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
