shardulm94 commented on a change in pull request #1781:
URL: https://github.com/apache/iceberg/pull/1781#discussion_r526584964
##########
File path: build.gradle
##########
@@ -607,6 +607,8 @@ project(':iceberg-hive-runtime') {
if (jdkVersion == '8') {
compile project(':iceberg-hive3')
}
+ // including thrift so that the Tez AM can communicate with the HMS when
using Hive catalog
+ compile("org.apache.thrift:libfb303")
Review comment:
Shouldn't this already be provided by Hive at runtime? Should Hive be
the one putting this on the AM?
If we need to include this, is it okay to not shade this? We usually shade
non Iceberg libraries in the runtime jars so that there aren't multiple jars
with same class names on the classpath, one from Iceberg and another from the
execution engine, causing conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
