blackmwk commented on PR #1876: URL: https://github.com/apache/iceberg-rust/pull/1876#issuecomment-3838184070
Hi, @emkornfield > I'll separate out the S3 fix into its own PR. > Use the new compression enum on MetadataLocation. I think this is the right direction to go. > If we can make breaking changes then: > > Then if write-to takes metadata location then we don't need to store compression codec on MetadataLocation at all (we can make it take a compression codec when generating the final path). (I actually need to double check this, there might be other places that try to reserialize the string). > We can eliminate a lot of the validation logic. This is the place where we have to make a breaking change, so I think it's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
