zhjwpku commented on code in PR #542: URL: https://github.com/apache/iceberg-cpp/pull/542#discussion_r2757876955
########## src/iceberg/transaction.h: ########## @@ -105,6 +105,9 @@ class ICEBERG_EXPORT Transaction : public std::enable_shared_from_this<Transacti /// and tags) and commit the changes. Result<std::shared_ptr<UpdateSnapshotReference>> NewUpdateSnapshotReference(); + /// \brief Create a new SnapshotManager to manage snapshots. Review Comment: My understanding is that `UpdateSnapshotReference` should be added to the `Transaction`'s pending updates, whereas `SnapshotManager` should no, just as Gang noted below, `SnapshotManager` has its own commit logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
