geruh commented on code in PR #15228:
URL: https://github.com/apache/iceberg/pull/15228#discussion_r2760930817
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -165,7 +165,7 @@ private static String convertToTypeString(Type type) {
}
return "timestamp";
case FIXED:
- case BINARY:
+ case BINARY, VARIANT:
Review Comment:
nit: we could add a comment explaining the binary representation.
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -165,7 +165,7 @@ private static String convertToTypeString(Type type) {
}
return "timestamp";
case FIXED:
- case BINARY:
Review Comment:
nit: this has mixed case styles i.e. fixed is stack on the comma separated
statements. Myabe we should keep everything on it's own line here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
