findepi commented on code in PR #15217:
URL: https://github.com/apache/iceberg/pull/15217#discussion_r2763014088
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -321,6 +321,11 @@ public Builder withSortOrder(SortOrder newSortOrder) {
return this;
}
+ public Builder withSortOrderId(int newSortOrderId) {
+ this.sortOrderId = newSortOrderId;
+ return this;
Review Comment:
> do we need assertions if the withSortOrder is setting some different sort
order id ?
>
> worth adding tests for someone who accidentally use both the APIs
This is not different than calling `withSortOrder` twice. The second call
wins. That's also how builders works typically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
