pvary commented on code in PR #15237:
URL: https://github.com/apache/iceberg/pull/15237#discussion_r2769462330
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -373,17 +363,21 @@ private DynamicIcebergSink build() {
generator != null, "Please use withGenerator() to convert the input
DataStream.");
Preconditions.checkNotNull(catalogLoader, "Catalog loader shouldn't be
null");
- FlinkWriteConf flinkWriteConf = new FlinkWriteConf(writeOptions,
readableConfig);
- Map<String, String> writeProperties =
- SinkUtil.writeProperties(flinkWriteConf.dataFileFormat(),
flinkWriteConf, null);
uidPrefix = Optional.ofNullable(uidPrefix).orElse("");
- return instantiateSink(writeProperties, flinkWriteConf);
+ final Configuration flinkConfig;
+ if (readableConfig instanceof Configuration) {
Review Comment:
Nit: What do you think about using this:
```
flinkConfig =
readableConfig instanceof Configuration config
? config
: Configuration.fromMap(readableConfig.toMap());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
