RussellSpitzer commented on code in PR #15241:
URL: https://github.com/apache/iceberg/pull/15241#discussion_r2770785667
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableChange.java:
##########
@@ -54,8 +56,33 @@ private TableChange(
this.commitCount = commitCount;
}
- TableChange(Snapshot snapshot, FileIO io) {
- this(snapshot.addedDataFiles(io), snapshot.addedDeleteFiles(io));
+ TableChange(Snapshot snapshot, Table table) {
Review Comment:
This is a bit of a messier change, The old version called a (this) but we
can't do that with the new Caching object since we can't init and access it
twice.
So the logic for doing the actual counts had to be moved into this method so
I could take advantage of the cache and not change performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
